Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: lock chromium major to 78 on 7-0-x #19552

Merged
merged 5 commits into from
Aug 2, 2019
Merged

build: lock chromium major to 78 on 7-0-x #19552

merged 5 commits into from
Aug 2, 2019

Conversation

MarshallOfSound
Copy link
Member

So that roller rolls correctly 馃憤

Notes: no-notes

codebytere
codebytere approved these changes Jul 31, 2019
View reviewed changes
Copy link
Member

@codebytere codebytere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃懝

@miniak
Copy link
Contributor

miniak commented Jul 31, 2019

ssl_security_state_tab_helper.patch has conflict

@MarshallOfSound MarshallOfSound requested a review from a team as a code owner August 2, 2019 08:01
@miniak
Copy link
Contributor

miniak commented Aug 2, 2019 •
edited

I've fixed ssl_security_state_tab_helper.patch and re-exported the patches. Should be ready to go. Hope you don't mind. I would like to start mirroring 7-0-x for our internal build, which currently expects Chromium version to be a a.b.c.d, not the commit hash.

@miniak
Copy link
Contributor

miniak commented Aug 2, 2019

@deepak1556 I took a few of your fixes from roller/chromium/master, can you please check?

@jkleinsc jkleinsc merged commit 9822953 into 7-0-x Aug 2, 2019
@release-clerk
Copy link

release-clerk bot commented Aug 2, 2019

No Release Notes

@jkleinsc jkleinsc deleted the lock-chromium-major branch August 2, 2019 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nornagon nornagon nornagon approved these changes

@alexeykuzmin alexeykuzmin alexeykuzmin approved these changes

@deepak1556 deepak1556 deepak1556 approved these changes

@miniak miniak miniak approved these changes

@codebytere codebytere codebytere approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@MarshallOfSound @miniak @nornagon @alexeykuzmin @deepak1556 @codebytere @jkleinsc